[Mesa-dev] [PATCH 10/15] i965/vec4: Remove broken vector size deduction in setup_builtin_uniform_values().

[Francisco Jerez]

Matt Turner <mattst88 at gmail.com> writes:

> On Fri, Mar 20, 2015 at 7:11 AM, Francisco Jerez <currojerez at riseup.net> wrote:
>> This seemed to be trying to deduce the number of uniform vector
>> components from the parameter swizzle, but the algorithm would always
>> give 4 as result.  Instead grab the correct number of components from
>> the GLSL type.
>> ---
>
> Functionally, what does this affect? Are we now packing uniforms more
> efficiently or something?

Yeah, mostly for fixed function stuff.  It should prevent some built-in
uniforms from taking up a full vec4 of constants even though they only
need less components.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 212 bytes
Desc: not available
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20150323/75aaf5ab/attachment.sig>