[Mesa-dev] [PATCH 3/6] i965: Create and use #defines for blitter constraints

Neil Roberts neil at linux.intel.com
Mon Mar 23 07:18:30 PDT 2015


Ben Widawsky <benjamin.widawsky at intel.com> writes:

> diff --git a/src/mesa/drivers/dri/i965/intel_blit.h b/src/mesa/drivers/dri/i965/intel_blit.h
> index f563939..531d329 100644
> --- a/src/mesa/drivers/dri/i965/intel_blit.h
> +++ b/src/mesa/drivers/dri/i965/intel_blit.h
> @@ -30,6 +30,9 @@
>  
>  #include "brw_context.h"
>  
> +#define INTEL_MAX_BLIT_PITCH 32768
> +#define INTEL_MAX_BLIT_ROWS 32768
> +

Isn't the actual maximum 32767 not 32768? I think it would be a lot less
confusing if we did that and then changed all of the ‘>=’ comparisons to
just ‘>’.

- Neil


More information about the mesa-dev mailing list