[Mesa-dev] [PATCH 3/6] i965: Create and use #defines for blitter constraints

[Ben Widawsky]

On Mon, Mar 23, 2015 at 02:18:30PM +0000, Neil Roberts wrote:
> Ben Widawsky <benjamin.widawsky at intel.com> writes:
> 
> > diff --git a/src/mesa/drivers/dri/i965/intel_blit.h b/src/mesa/drivers/dri/i965/intel_blit.h
> > index f563939..531d329 100644
> > --- a/src/mesa/drivers/dri/i965/intel_blit.h
> > +++ b/src/mesa/drivers/dri/i965/intel_blit.h
> > @@ -30,6 +30,9 @@
> >  
> >  #include "brw_context.h"
> >  
> > +#define INTEL_MAX_BLIT_PITCH 32768
> > +#define INTEL_MAX_BLIT_ROWS 32768
> > +
> 
> Isn't the actual maximum 32767 not 32768? I think it would be a lot less
> confusing if we did that and then changed all of the ‘>=’ comparisons to
> just ‘>’.
> 
> - Neil

I can do that, but I'd like to keep the rename and the modification as separate
patches. Though they should bother have no functional impact, I like to keep
rename patches distinct. Is that okay?

-- 
Ben Widawsky, Intel Open Source Technology Center