[Mesa-dev] [PATCH 0/9] NIR: Several optimization patches

[Matt Turner]

On Tue, Mar 31, 2015 at 10:46 AM, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Mar 23, 2015 at 8:13 PM, Jason Ekstrand <jason at jlekstrand.net> wrote:
>> This series contains several optimization-related patches that are all
>> focussed around being able to do better at emitting MAD instructions.
>>
>> Final shader-db results for the whole series on Haswell:
>>
>>    total NIR instructions in shared programs: 2183472 -> 2152911 (-1.40%)
>>    NIR instructions in affected programs:     1299664 -> 1269103 (-2.35%)
>>    helped:                                    7106
>>    HURT:                                      321
>>
>>    total FS instructions in shared programs:  4419884 -> 4378433 (-0.94%)
>>    FS instructions in affected programs:      1895564 -> 1854113 (-2.19%)
>>    helped:                                    10025
>>    HURT:                                      221
>>    GAINED:                                    81
>>    LOST:                                      8
>>
>> There is one notable place where this hurts us.  There are three shaders in
>> Kerbal Space Program that now spill.  However, this does not seem to be the
>> fault of NIR.  See patch 8 for more details.
>>
>> Jason Ekstrand (9):
>>   nir/algebraic: #define around structure definitions
>>   nir/algebraic: Add a seperate section for "late" optimizations
>>   i965/nir: Use the late optimizations
>>   nir: Move the compare-with-zero optimizations to the late section
>>   nir: Add a dedicated ffma peephole optimization
>>   i965/nir: Use the dedicated ffma peephole
>>   nir/peephole_ffma: Be less agressive about fusing multiply-adds
>>   i965/nir: Run the ffma peephole after the rest of the optimizations
>>   i965: Use the same nir options for all gens
>
> 1-3 are Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
> 2+3 should be squashed together.
>
> Part of 4 looks like it should be a separate commit.

I replied to this, and assuming my understanding is correct

Reviewed-by: Matt Turner <mattst88 at gmail.com>

> Haven't reviewed 5, but should probably squash 5+6.
>
> 7 is Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
> 8 - should split the DCE hunk into a separate patch.

With the DCE hunk split out, both patches are

Reviewed-by: Matt Turner <mattst88 at gmail.com>

> 9 is Reviewed-by: Matt Turner <mattst88 at gmail.com>