[Mesa-dev] [PATCH 02/20] mesa: Remove all vestiges of glFramebufferTextureFaceARB

[Ian Romanick]

On 05/14/2015 02:44 PM, Emil Velikov wrote:
> On 13/05/15 19:44, Ian Romanick wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> Mesa does not (and probably never will) support GL_ARB_geometry_shader4,
>> so this function will never exist.
> In the (very unlikely) event that we do support the extension, won't
> this change cause issues when mixing libGL/libglapi/dri modules ?
> 
>>  Having a function that is
>> exec="skip" and offset="assign" is just weird.
>>
> We have a few more of those (barring the deprecated ones):
> SampleMaskSGIS
> SamplePatternSGIS
> ResizeBuffersMESA
> 
> Should we do the same for them as well, or perhaps just mention why
> they're "left behind" ?

I think ResizeBuffersMESA could also go away.  The SGIS_multisample
functions are supported for indirect rendering interoperability.  If any
of those functions are removed, we'll also have to remove the extension
strings from src/glx/glxextensions.c.  The strangeness for all 3
functions mostly goes away in patches 13 and 15.

How about if I add a note to the commit message and send a follow-up
patch for after the branch point?

> -Emil