[Mesa-dev] Mesa (master): 57 new commits

[Ian Romanick]

On 05/15/2015 12:10 PM, Fredrik Höglund wrote:
> On Friday 15 May 2015, Ian Romanick wrote:
>> On 05/15/2015 05:26 AM, Fredrik Höglund wrote:
>>> On Friday 15 May 2015, Michel Dänzer wrote:
>>>> On 14.05.2015 22:52, fredrik at kemper.freedesktop.org (Fredrik HXXglund)
>>>> wrote:
>>>>>
>>>>> URL:
>>>> http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b284f08ab399154ad10e2166440b44cbbdcb2c5
>>>>> Author: Laura Ekstrand <laura at jlekstrand.net>
>>>>> Date:   Tue Feb 3 14:47:00 2015 -0800
>>>>>
>>>>>     main: _mesa_blit_framebuffer updates its arbitrary framebuffers.
>>>>>     
>>>>>     Previously, we used _mesa_update_state to update the currently bound
>>>>>     framebuffers prior to performing a blit.  Now that _mesa_blit_framebuffer
>>>>>     uses arbitrary framebuffers, _mesa_update_state is not specific enough.
>>>>>     
>>>>>     Reviewed-by: Fredrik Höglund <fredrik at kde.org>
>>>>>     Signed-off-by: Fredrik Höglund <fredrik at kde.org>
>>>>
>>>> This commit broke the piglit test
>>>> spec at ext_framebuffer_multisample@bitmap with the radeonsi driver:
>>>>
>>>> Probe color at (224,0)
>>>>   Left: 0.000000 0.000000 0.000000 1.000000
>>>>   Right: 1.000000 1.000000 1.000000 1.000000
>>>>
>>>> Looks like it's because the bottom right squares of the Xs are missing,
>>>> see the attached picture.
>>>>
>>>> Any ideas?
>>>
>>> I did notice that failure as well, but when I ran the test manually it
>>> passed for me, leading me to think that it was a spurious failure.
>>>
>>> The output looks exactly the same for me.  But the test works by
>>> comparing the left and right halves of the framebuffer, so if the
>>> bottom right squares are missing on both sides, the test should
>>> pass.  
>>>
>>> The left side is the test image, and the right side is the reference
>>> image.
>>
>> I'm also going to say that I'm quite pissed that this series landed
>> without my objections being addressed.  I've half a mind to revert the
>> whole lot!
> 
> I posted an email Monday morning US time asking for feedback on this.
> That was five days ago today.  Where is your reply to that email?
> Laura's framebuffer patches have been sitting on the mailing list for ten
> weeks now without anyone reviewing them but me.
> 
> I poked several people on IRC (yourself included), pointed to that email,
> explained the situation and asked what I should do.  The only person who
> would give me a straight answer was Ilia, who said that he preferred not
> enabling the extension in the core profile if it meant that some piglit
> tests would skip until they've been ported.
> 
> I'm quite dissapointed that people wait until after the patches have
> landed before they speak their mind.

To quote from my reply to your patch 44:

   "Add this to the list of arguments for making this extension
   exclusive to core profile... which I have been saying since
   before a single line of DSA code was written."

I have been speaking my mind on this topic since Dylan Noblesmith worked
on it for GSoC *TWO YEARS AGO*.

http://lists.freedesktop.org/archives/mesa-dev/2013-September/044940.html

This is not a new objection, nor has it been a quiet objection.

> Fredrik