[Mesa-dev] [RFC 00/10] Enable support for 2D ASTC HDR and LDR formats

[Jason Ekstrand]

On Tue, May 19, 2015 at 7:08 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> Hi Nanley,
>
> I was expecting to see some code dealing with the fact that the block
> sizes are all different. Did I miss it, or is that still on the TODO
> list?

I think *most* of that code *should* already be there.  In theory,
it's all keyed off of the block size provided by formats.csv.
However, given some of the rendering errors we're currently seeing, it
looks like it may need a little patching here and there. :-)
--Jason

> Cheers,
>
>   -ilia
>
> P.S. Congrats on your first public patch submission to mesa-dev :)
>
> On Tue, May 19, 2015 at 8:48 PM, Nanley Chery <nanleychery at gmail.com> wrote:
>> From: Nanley Chery <nanley.g.chery at intel.com>
>>
>> This patch series adds support for the KHR_texture_compression_astc_{ldr,hdr}
>> extensions. The last two commits enable support for Skylake systems.
>>
>> Some rendering issues were encountered during testing, so there is some more
>> work to be done on this feature. The Piglit tests for this extension can be
>> found here: cgit.freedesktop.org/~nchery/piglit
>>
>> Nanley Chery (10):
>>   mesa/formats: define the 2D ASTC formats
>>   glapi: add support for KHR_texture_compression_astc_ldr
>>   mesa: disable online compression for ASTC formats
>>   mesa: add ASTC extensions to the extensions table
>>   mesa/glformats: recognize ASTC formats as compressed
>>   mesa/texcompress: enable translation between MESA and GL ASTC formats
>>   mesa/teximage: return the base internal format of the ASTC formats
>>   mesa/formats: store whether or not a format is sRGB in gl_format_info
>>   i965/surface_formats: add support for 2D ASTC surface formats
>>   i965: enable ASTC support for Skylake
>>
>>  .../glapi/gen/KHR_texture_compression_astc.xml     |  40 ++++++
>>  src/mapi/glapi/gen/Makefile.am                     |   1 +
>>  src/mapi/glapi/gen/gl_API.xml                      |   2 +-
>>  src/mesa/drivers/dri/i965/brw_defines.h            |  36 +++++
>>  src/mesa/drivers/dri/i965/brw_surface_formats.c    |  67 ++++++++-
>>  src/mesa/drivers/dri/i965/intel_extensions.c       |   6 +
>>  src/mesa/main/extensions.c                         |   3 +
>>  src/mesa/main/format_info.py                       |   5 +
>>  src/mesa/main/formats.c                            | 159 +++++++++++++++++----
>>  src/mesa/main/formats.csv                          |  31 ++++
>>  src/mesa/main/formats.h                            |  30 ++++
>>  src/mesa/main/glformats.c                          |  29 ++++
>>  src/mesa/main/mtypes.h                             |   3 +
>>  src/mesa/main/texcompress.c                        | 136 ++++++++++++++++++
>>  src/mesa/main/teximage.c                           |  64 +++++++++
>>  src/mesa/swrast/s_texfetch.c                       |  32 ++++-
>>  16 files changed, 616 insertions(+), 28 deletions(-)
>>  create mode 100644 src/mapi/glapi/gen/KHR_texture_compression_astc.xml
>>
>> --
>> 2.4.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev