[Mesa-dev] [RFC 00/10] Enable support for 2D ASTC HDR and LDR formats

Neil Roberts neil at linux.intel.com
Wed May 20 09:52:06 PDT 2015

Jason Ekstrand <jason at jlekstrand.net> writes:

> I think *most* of that code *should* already be there.  In theory,
> it's all keyed off of the block size provided by formats.csv.
> However, given some of the rendering errors we're currently seeing, it
> looks like it may need a little patching here and there. :-)

intel_vertical_texture_alignment_unit is one place where we definitely
are hardcoding the block height to 4 (as currently even FXT1 has a block
*height* of 4). I guess the bit under if(is_format_compressed) would
need to be changed to be more like the one for the horizontal texture
alignment where it fetches the block size and multiplies it by 4 on

It might be worth combining those two functions into one so that for the
compressed case it could query the block size just once and we could
avoid duplicating the comment.

- Neil

More information about the mesa-dev mailing list