[Mesa-dev] [v3 PATCH 03/10] mesa: Complete implementation for ARB_framebuffer_no_attachments in Mesa core

[Matt Turner]

On Thu, May 21, 2015 at 2:30 PM,  <kevin.rogovin at intel.com> wrote:
> From: Kevin Rogovin <kevin.rogovin at intel.com>
>
> Implement GL_ARB_framebuffer_no_attachments in Mesa core
>  - changes to conditions for framebuffer completenss
>  - implement set/get functions for framebuffers for
>    new functions in GL_ARB_framebuffer_no_attachments
>
> v1 -> v2
>  Spacing and exceed 80 characters per line fixes.
>
> v2 -> v3
>  Implement DSA functions of extension.
>
>
> Signed-off-by: Kevin Rogovin <kevin.rogovin at intel.com>
> ---
>  src/mesa/main/fbobject.c | 217 ++++++++++++++++++++++++++++++++++++++++-------
>  1 file changed, 184 insertions(+), 33 deletions(-)
>
> diff --git a/src/mesa/main/fbobject.c b/src/mesa/main/fbobject.c
> index 4ac3f20..18def71 100644
> --- a/src/mesa/main/fbobject.c
> +++ b/src/mesa/main/fbobject.c
> @@ -1156,14 +1156,49 @@ _mesa_test_framebuffer_completeness(struct gl_context *ctx,
>        } else if (att_layer_count > max_layer_count) {
>           max_layer_count = att_layer_count;
>        }
> +
> +      /**
> +       * The extension GL_ARB_framebuffer_no_attachments places the additional
> +       * requirement on each attachment that
> +       *
> +       * "The width and height of image are greater than zero and less than or
> +       *  equal to the values of the implementation-dependent limits
> +       *  MAX_FRAMEBUFFER_WIDTH and MAX_FRAMEBUFFER_HEIGHT, respectively. "

Extra space between . and "

> +       *
> +       * "If <image> is a three-dimensional texture or a one- or two-dimensional
> +       *  array texture and the attachment is layered, the depth or layer count
> +       *  of the texture is less than or equal to the implementation-dependent
> +       *  limit MAX_FRAMEBUFFER_LAYERS."
> +       *
> +       * "If image has multiple samples, its sample count is less than or equal
> +       *  to the value of the implementation-dependent limit MAX_FRAMEBUFFER_-
> +       *  SAMPLES ."

Extra space before .

Also, if anyone is ever grepping for MAX_FRAMEBUFFER_SAMPLES, they
won't find this. I'd move the whole word to the next line.

> +       *
> +       * The same requirements are also in place for GL 4.5,
> +       * Section 9.4.1 "Framebuffer Attachment Completeness", pg 310-311
> +       *
> +       * However, this is a tighter restriction than previous version of GL.
> +       * In interest of better compatibility, we will not enforce these
> +       * restrictions.
> +       */

Comment at the end of a block like this looks strange. I'm not sure
what it's commenting on.
>     }