[Mesa-dev] [PATCH 00/24] i965: Refactor register classes

Emil Velikov emil.l.velikov at gmail.com
Fri Nov 6 04:57:08 PST 2015


Hi Matt,

A short summary

 [PATCH 06/24] i965: Add and use enum brw_reg_file.
s/GRF/BRW_ARCHITECTURE_REGISTER_FILE/ - already addressed in your branch.

 [PATCH 12/24] i965: Initialize registers' file to BAD_FILE.
With the fs_visitor::init() hunk dropped and memset(this->outputs,
0...) removed.

 [PATCH 18/24] i965: Combine register file field.
Please squash the two fixup patches that I've sent.

 [PATCH 20/24] Revert "i965: Have brw_imm_vf4() take the vector
components as integer values."
Regardless if VF_ZERO/ONE or brw_float_to_vf() is used.

 [PATCH 23/24] i965/vec4: Replace src_reg(imm) constructors with brw_imm_*().
Keep the memcpy(), although we really should address the uninitialised
imm[] warning/bug. In a separate commit of course and optionally nuke
the memcpy.

With these and a jenkins spin to catch any subtle bugs the series is
Reviewed-by: Emil Velikov <emil.velikov at collabora.co.uk>

Thanks again for reworking/clearing these up.
-Emil


More information about the mesa-dev mailing list