[Mesa-dev] [PATCH 2/7] nir: remove nir_variable::max_ifc_array_access

Jason Ekstrand jason at jlekstrand.net
Fri Nov 6 15:21:54 PST 2015


Yes, please!

Reviewed-by: Jason Ekstrand <jason.ekstrand at intel.com>

On Fri, Nov 6, 2015 at 8:35 AM, Rob Clark <robdclark at gmail.com> wrote:
> From: Rob Clark <robclark at freedesktop.org>
>
> No users.
>
> Signed-off-by: Rob Clark <robclark at freedesktop.org>
> ---
>  src/glsl/nir/glsl_to_nir.cpp |  9 ---------
>  src/glsl/nir/nir.h           | 13 -------------
>  2 files changed, 22 deletions(-)
>
> diff --git a/src/glsl/nir/glsl_to_nir.cpp b/src/glsl/nir/glsl_to_nir.cpp
> index 57aba5b..0854a52 100644
> --- a/src/glsl/nir/glsl_to_nir.cpp
> +++ b/src/glsl/nir/glsl_to_nir.cpp
> @@ -291,15 +291,6 @@ nir_visitor::visit(ir_variable *ir)
>     var->type = ir->type;
>     var->name = ralloc_strdup(var, ir->name);
>
> -   if (ir->is_interface_instance() && ir->get_max_ifc_array_access() != NULL) {
> -      unsigned size = ir->get_interface_type()->length;
> -      var->max_ifc_array_access = ralloc_array(var, unsigned, size);
> -      memcpy(var->max_ifc_array_access, ir->get_max_ifc_array_access(),
> -             size * sizeof(unsigned));
> -   } else {
> -      var->max_ifc_array_access = NULL;
> -   }
> -
>     var->data.read_only = ir->data.read_only;
>     var->data.centroid = ir->data.centroid;
>     var->data.sample = ir->data.sample;
> diff --git a/src/glsl/nir/nir.h b/src/glsl/nir/nir.h
> index e2d75df..0d98847 100644
> --- a/src/glsl/nir/nir.h
> +++ b/src/glsl/nir/nir.h
> @@ -148,19 +148,6 @@ typedef struct {
>      */
>     char *name;
>
> -   /**
> -    * For variables which satisfy the is_interface_instance() predicate, this
> -    * points to an array of integers such that if the ith member of the
> -    * interface block is an array, max_ifc_array_access[i] is the maximum
> -    * array element of that member that has been accessed.  If the ith member
> -    * of the interface block is not an array, max_ifc_array_access[i] is
> -    * unused.
> -    *
> -    * For variables whose type is not an interface block, this pointer is
> -    * NULL.
> -    */
> -   unsigned *max_ifc_array_access;
> -
>     struct nir_variable_data {
>
>        /**
> --
> 2.5.0
>


More information about the mesa-dev mailing list