[Mesa-dev] [PATCH 3/3] glsl: Use shared storage variable type for shared variables

[Timothy Arceri]

On Fri, 2015-11-06 at 17:56 -0800, Jordan Justen wrote:
> Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
> ---
>  src/glsl/ast_to_hir.cpp | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/src/glsl/ast_to_hir.cpp b/src/glsl/ast_to_hir.cpp
> index dd5ba4e..4ef770f 100644
> --- a/src/glsl/ast_to_hir.cpp
> +++ b/src/glsl/ast_to_hir.cpp
> @@ -2790,6 +2790,8 @@ apply_type_qualifier_to_variable(const struct
> ast_type_qualifier *qual,
>        var->data.mode = ir_var_uniform;
>     else if (qual->flags.q.buffer)
>        var->data.mode = ir_var_shader_storage;
> +   else if (qual->flags.q.shared)

If you introduce a new flag as suggested in my feedback for patch 1 then:

Reviewed-by: Timothy Arceri <timothy.arceri at collabora.com>

> +      var->data.mode = ir_var_shader_shared; 
>     if (!is_parameter && is_varying_var(var, state->stage)) {
>        /* User-defined ins/outs are not permitted in compute shaders. */