[Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

Emil Velikov emil.l.velikov at gmail.com
Sun Nov 8 05:12:03 PST 2015


Hi Mauro,

On 8 November 2015 at 12:59, Mauro Rossi <issor.oruam at gmail.com> wrote:
> Update2: I'm getting the building error in both x86 target and x86_64
> target.
>
> I'm relieved it's not arch dependend, I suspect that export will require a
> dependency to be declared,
>  because if i965_dri module is built before glsl ones we will have the
> error.
>
> The LOCAL_C_INCLUDES even if not elegant, avoided the problem in the first
> place,
> but I'd like to learn the by the best practice and apply it in the future.
>
Fwiw I'm all for LOCAL_C_INCLUDES (I even mentioned a few times a way
that we can share those and minimise these issues), but I believe
Chih-Wei was not really a fan of them. If he's ok with it I'll push
your original patch.

Regards,
Emil

P.S. Typos - for each one we fix, another we introduce another one or more  :-P


More information about the mesa-dev mailing list