[Mesa-dev] [PATCH] android: fix LOCAL_C_INCLUDES to find glsl_types.h

[Mauro Rossi]

Hi Emil,

I checked with Chih-Wei and LOCAL_EXPORT_C_INCLUDE_DIRS is the preferred
way.

I took the chance to finally understand why the single line of change you
proposed will suffice,
it's because glsl_compiler module invokes libmesa_glsl as static library
and the same applies to i965_dri module.

My last problem was probably due to uncleaned mesa targets folders in $OUT
path,
now I have checked again and building errors are gone.

Thanks a lot Emil and Chih-Wei

Mauro

2015-11-08 14:12 GMT+01:00 Emil Velikov <emil.l.velikov at gmail.com>:

> Hi Mauro,
>
> On 8 November 2015 at 12:59, Mauro Rossi <issor.oruam at gmail.com> wrote:
> > Update2: I'm getting the building error in both x86 target and x86_64
> > target.
> >
> > I'm relieved it's not arch dependend, I suspect that export will require
> a
> > dependency to be declared,
> >  because if i965_dri module is built before glsl ones we will have the
> > error.
> >
> > The LOCAL_C_INCLUDES even if not elegant, avoided the problem in the
> first
> > place,
> > but I'd like to learn the by the best practice and apply it in the
> future.
> >
> Fwiw I'm all for LOCAL_C_INCLUDES (I even mentioned a few times a way
> that we can share those and minimise these issues), but I believe
> Chih-Wei was not really a fan of them. If he's ok with it I'll push
> your original patch.
>
> Regards,
> Emil
>
> P.S. Typos - for each one we fix, another we introduce another one or
> more  :-P
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151114/8c45df63/attachment.html>