[Mesa-dev] [PATCH 1/2] i965: Add INTEL_DEBUG=tcs, tes and hs, ds flags for tessellation shaders.

[Tapani Pälli]

Both patches are

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

On 11/17/2015 02:36 AM, Kenneth Graunke wrote:
> Even though both tessellation shader stages must be used together, I
> still think it makes sense to add separate debug flags for each stage.
> It makes it possible to read the TCS/HS, rule out problems, then read
> the TES/DS separately, without sifting through as much printed text.
>
> I decided to add both the GL names (tcs/tes) and hardware names (hs/ds)
> so they can be used interchangeably.
>
> Signed-off-by: Kenneth Graunke <kenneth at whitecape.org>
> ---
>   src/mesa/drivers/dri/i965/intel_debug.c | 8 ++++++--
>   src/mesa/drivers/dri/i965/intel_debug.h | 2 ++
>   2 files changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_debug.c b/src/mesa/drivers/dri/i965/intel_debug.c
> index c00d2e7..f53c4ab 100644
> --- a/src/mesa/drivers/dri/i965/intel_debug.c
> +++ b/src/mesa/drivers/dri/i965/intel_debug.c
> @@ -75,6 +75,10 @@ static const struct debug_control debug_control[] = {
>      { "cs",          DEBUG_CS },
>      { "hex",         DEBUG_HEX },
>      { "nocompact",   DEBUG_NO_COMPACTION },
> +   { "hs",          DEBUG_TCS },
> +   { "tcs",         DEBUG_TCS },
> +   { "ds",          DEBUG_TES },
> +   { "tes",         DEBUG_TES },
>      { NULL,    0 }
>   };
>
> @@ -83,8 +87,8 @@ intel_debug_flag_for_shader_stage(gl_shader_stage stage)
>   {
>      uint64_t flags[] = {
>         [MESA_SHADER_VERTEX] = DEBUG_VS,
> -      [MESA_SHADER_TESS_CTRL] = 0,
> -      [MESA_SHADER_TESS_EVAL] = 0,
> +      [MESA_SHADER_TESS_CTRL] = DEBUG_TCS,
> +      [MESA_SHADER_TESS_EVAL] = DEBUG_TES,
>         [MESA_SHADER_GEOMETRY] = DEBUG_GS,
>         [MESA_SHADER_FRAGMENT] = DEBUG_WM,
>         [MESA_SHADER_COMPUTE] = DEBUG_CS,
> diff --git a/src/mesa/drivers/dri/i965/intel_debug.h b/src/mesa/drivers/dri/i965/intel_debug.h
> index 98bd7e9..9c6030a 100644
> --- a/src/mesa/drivers/dri/i965/intel_debug.h
> +++ b/src/mesa/drivers/dri/i965/intel_debug.h
> @@ -69,6 +69,8 @@ extern uint64_t INTEL_DEBUG;
>   #define DEBUG_CS                  (1ull << 33)
>   #define DEBUG_HEX                 (1ull << 34)
>   #define DEBUG_NO_COMPACTION       (1ull << 35)
> +#define DEBUG_TCS                 (1ull << 36)
> +#define DEBUG_TES                 (1ull << 37)
>
>   #ifdef HAVE_ANDROID_PLATFORM
>   #define LOG_TAG "INTEL-MESA"
>