[Mesa-dev] [PATCH] st/va: add missing break statement

[Christian König]

On 29.11.2015 12:48, Emil Velikov wrote:
> Earlier commit factored out the mpeg4 IQ matrix handling into separate
> function, although it forgot to add a break in its case statement.
> Thus the data ended up partially overwritten as the mpeg4 and h265
> structs are members of the desc union.
>
> Spotted by Coverity (CID 1341052)
>
> Fixes: 64761a841db "st/va: move MPEG4 functions into separate file"
> Cc: Christian König <christian.koenig at amd.com>
> Cc: Julien Isorce <j.isorce at samsung.com>
> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>

Crap, stupid typo. Patch is Reviewed-by: Christian König 
<christian.koenig at amd.com>

> ---
>   src/gallium/state_trackers/va/picture.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/src/gallium/state_trackers/va/picture.c b/src/gallium/state_trackers/va/picture.c
> index 5f703eb..34e7d55 100644
> --- a/src/gallium/state_trackers/va/picture.c
> +++ b/src/gallium/state_trackers/va/picture.c
> @@ -281,6 +281,7 @@ handleIQMatrixBuffer(vlVaContext *context, vlVaBuffer *buf)
>   
>      case PIPE_VIDEO_FORMAT_MPEG4:
>         vlVaHandleIQMatrixBufferMPEG4(context, buf);
> +      break;
>   
>      case PIPE_VIDEO_FORMAT_HEVC:
>         assert(buf->size >= sizeof(VAIQMatrixBufferH264) && buf->num_elements == 1);