[Mesa-dev] [PATCH] st/va: add missing break statement

[Emil Velikov]

On 29 November 2015 at 11:52, Christian König <christian.koenig at amd.com> wrote:
> On 29.11.2015 12:48, Emil Velikov wrote:
>>
>> Earlier commit factored out the mpeg4 IQ matrix handling into separate
>> function, although it forgot to add a break in its case statement.
>> Thus the data ended up partially overwritten as the mpeg4 and h265
>> structs are members of the desc union.
>>
>> Spotted by Coverity (CID 1341052)
>>
>> Fixes: 64761a841db "st/va: move MPEG4 functions into separate file"
>> Cc: Christian König <christian.koenig at amd.com>
>> Cc: Julien Isorce <j.isorce at samsung.com>
>> Signed-off-by: Emil Velikov <emil.l.velikov at gmail.com>
>
>
> Crap, stupid typo. Patch is Reviewed-by: Christian König
> <christian.koenig at amd.com>
>
That's why I like static analysis tools - didn't spot the missing
break either :-)

Thanks
Emil