[Mesa-dev] [PATCH 1/2] i965/mt: Declare some functions as static

Anuj Phogat anuj.phogat at gmail.com
Thu Oct 1 09:36:58 PDT 2015


On Thu, Oct 1, 2015 at 8:20 AM, Chad Versace <chad.versace at intel.com> wrote:
> intel_tiling_supports_non_msrt_mcs() and
> intel_miptree_is_fast_clear_capable() are not used outside of
> intel_mipmap_tree.c.
> ---
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.c | 4 ++--
>  src/mesa/drivers/dri/i965/intel_mipmap_tree.h | 6 +-----
>  2 files changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> index ffc356c..05dc291 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.c
> @@ -160,7 +160,7 @@ intel_get_non_msrt_mcs_alignment(struct intel_mipmap_tree *mt,
>     }
>  }
>
> -bool
> +static bool
>  intel_tiling_supports_non_msrt_mcs(struct brw_context *brw, unsigned tiling)
>  {
>     /* From the Ivy Bridge PRM, Vol2 Part1 11.7 "MCS Buffer for Render
> @@ -193,7 +193,7 @@ intel_tiling_supports_non_msrt_mcs(struct brw_context *brw, unsigned tiling)
>   *     - MCS buffer for non-MSRT is supported only for RT formats 32bpp,
>   *       64bpp, and 128bpp.
>   */
> -bool
> +static bool
>  intel_miptree_is_fast_clear_capable(struct brw_context *brw,
>                                      struct intel_mipmap_tree *mt)
>  {
> diff --git a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> index 486e5c6..805cd71 100644
> --- a/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> +++ b/src/mesa/drivers/dri/i965/intel_mipmap_tree.h
> @@ -658,11 +658,7 @@ struct intel_mipmap_tree
>  void
>  intel_get_non_msrt_mcs_alignment(struct intel_mipmap_tree *mt,
>                                   unsigned *width_px, unsigned *height);
> -bool
> -intel_tiling_supports_non_msrt_mcs(struct brw_context *brw, unsigned tiling);
> -bool
> -intel_miptree_is_fast_clear_capable(struct brw_context *brw,
> -                                    struct intel_mipmap_tree *mt);
> +
>  bool
>  intel_miptree_alloc_non_msrt_mcs(struct brw_context *brw,
>                                   struct intel_mipmap_tree *mt);
> --
> 2.5.0.342.g44e0223
>
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


Both patches are:
Reviewed-by: Anuj Phogat <anuj.phogat at gmail.com>


More information about the mesa-dev mailing list