[Mesa-dev] [PATCH v2 1/2] nir/lower_io: Return has_indirect flag from get_io_offset().

[Kenneth Graunke]

On Friday, October 02, 2015 12:08:07 PM Jason Ekstrand wrote:
> On Thu, Oct 1, 2015 at 11:13 AM, Kenneth Graunke <kenneth at whitecape.org> wrote:
> > get_io_offset() already walks the dereference chain and discovers
> > whether or not we have an indirect; we can just return that rather than
> > computing it a second time.  This means moving the call a bit earlier.
> >
> > More importantly, I'm about to introduce special handling for the
> > outermost array index, which would require changing the dereference
> > we pass to deref_has_indirect().  Or we can just eliminate that.
> 
> I think I actually like what we did in nir_lower_samplers a bit
> better.  There we just made indirect a nir_ssa_def* and NULL means no
> indirect.  Since these passes all happen while we're in SSA form, that
> works pretty well.  Thoughts?

Yeah, I like that better.  I'll resend.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151002/b23debe1/attachment-0001.sig>