[Mesa-dev] [PATCH 1/4] i965: Don't print line numbers with INTEL_DEBUG=optimizer.

[Alejandro Piñeiro]

Not sure if this series in general was discarded after Matt's second
email on "Add a pass to predicate short blocks", but in any case, I find
this specific patch useful and LGTM. Just in case you were expecting for
someone taking a look to it:

Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>


On 29/09/15 00:26, Matt Turner wrote:
> The thing you want to do with the output files is diff them, which is
> made more difficult by line numbers changing.
> ---
>  src/mesa/drivers/dri/i965/brw_shader.cpp | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
>
> diff --git a/src/mesa/drivers/dri/i965/brw_shader.cpp b/src/mesa/drivers/dri/i965/brw_shader.cpp
> index 785cb27..15e340d 100644
> --- a/src/mesa/drivers/dri/i965/brw_shader.cpp
> +++ b/src/mesa/drivers/dri/i965/brw_shader.cpp
> @@ -1331,13 +1331,15 @@ backend_shader::dump_instructions(const char *name)
>     if (cfg) {
>        int ip = 0;
>        foreach_block_and_inst(block, backend_instruction, inst, cfg) {
> -         fprintf(file, "%4d: ", ip++);
> +         if (!unlikely(INTEL_DEBUG & DEBUG_OPTIMIZER))
> +            fprintf(file, "%4d: ", ip++);
>           dump_instruction(inst, file);
>        }
>     } else {
>        int ip = 0;
>        foreach_in_list(backend_instruction, inst, &instructions) {
> -         fprintf(file, "%4d: ", ip++);
> +         if (!unlikely(INTEL_DEBUG & DEBUG_OPTIMIZER))
> +            fprintf(file, "%4d: ", ip++);
>           dump_instruction(inst, file);
>        }
>     }

-- 
Alejandro Piñeiro (apinheiro at igalia.com)