[Mesa-dev] [PATCH] egl/dri2: expose srgb configs when KHR_gl_colorspace is available

Emil Velikov emil.l.velikov at gmail.com
Sat Oct 3 04:19:39 PDT 2015


On 3 October 2015 at 02:12, Marek Olšák <maraeo at gmail.com> wrote:
> I'm not sure if this is correct or if we should just return NULL in
> this case like the "case" statement above that does.
>
Actually I was thinking about bailing out when the requested attribute
is set. I.e.

diff --git a/src/egl/drivers/dri2/egl_dri2.c b/src/egl/drivers/dri2/egl_dri2.c
index 1740ee3..0450269 100644
--- a/src/egl/drivers/dri2/egl_dri2.c
+++ b/src/egl/drivers/dri2/egl_dri2.c
@@ -237,6 +237,8 @@ dri2_add_config(_EGLDisplay *disp, const
__DRIconfig *dri_config, int id,

      case __DRI_ATTRIB_FRAMEBUFFER_SRGB_CAPABLE:
         srgb = value != 0;
+         if (!dpy->Extensions.KHR_gl_colorspace && srgb)
+            return NULL;
         break;

      default:


-Emil


More information about the mesa-dev mailing list