[Mesa-dev] [PATCH 2/2] i965: Fix intel_miptree_is_fast_clear_capable()
chad.versace at intel.com
Mon Oct 5 11:15:07 PDT 2015
On Thu 01 Oct 2015, Ben Widawsky wrote:
> On Thu, Oct 01, 2015 at 08:20:07AM -0700, Chad Versace wrote:
> > There are three types of fast clears:
> > a. fast depth clears
> > b. fast singlesample color clears
> > c. fast multisample color clears
> > Function intel_miptree_is_fast_clear_capable() checks if a miptree
> > supports fast clears of type (b).
> > Rename the function to disambiguate what it does:
> > old: intel_miptree_is_fast_clear_capable
> > new: intel_miptree_supports_non_msrt_fast_clear
> > The functionally *accidentally* rejected multisampled color surfaces
> > because it thought they were singlesample array surfaces. Fix that by
> > explicitly rejecting surfaces with samples > 1.
> I wasn't going to say anything except you put "accidentally" in bold. I
> don't think you can determine what Paul was thinking when he originally
> implemented that code. Calling it accidental is unnecessarily judgmental (as is
> my response here). The code was correct, and unless you want to ask him, we
> should assume it was intentional.
Ok, I removed the asterisks around "accidentally".
More information about the mesa-dev