[Mesa-dev] [PATCH] c11/threads: initialize timeout structure
Ian Romanick
idr at freedesktop.org
Tue Oct 6 10:38:35 PDT 2015
I had also noticed the unused parameter warning, but I had a patch that
just papered over the problem. I'm a bit annoyed that GCC didn't warn
(but I guess it couldn't really) that abs_time might be used uninitialized.
This patch is
Reviewed-by: Ian Romanick <ian.d.romanick at intel.com>
On 10/03/2015 05:19 PM, Jan Vesely wrote:
> Signed-off-by: Jan Vesely <jano.vesely at gmail.com>
> ---
> include/c11/threads_posix.h | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/include/c11/threads_posix.h b/include/c11/threads_posix.h
> index 3def6c4..ce9853b 100644
> --- a/include/c11/threads_posix.h
> +++ b/include/c11/threads_posix.h
> @@ -136,8 +136,14 @@ cnd_timedwait(cnd_t *cond, mtx_t *mtx, const xtime *xt)
> {
> struct timespec abs_time;
> int rt;
> +
> assert(mtx != NULL);
> assert(cond != NULL);
> + assert(xt != NULL);
> +
> + abs_time.tv_sec = xt->sec;
> + abs_time.tv_nsec = xt->nsec;
> +
> rt = pthread_cond_timedwait(cond, mtx, &abs_time);
> if (rt == ETIMEDOUT)
> return thrd_busy;
>
More information about the mesa-dev
mailing list