[Mesa-dev] [PATCH] egl: restore surface type before linking config to its display

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 6 10:45:32 PDT 2015


On 6 October 2015 at 17:24, Varad Gautam <varadgautam at gmail.com> wrote:
> commit c2c2e9a (egl: implement EGL_KHR_gl_colorspace (v2)) leaves
> _EGLConfig->SurfaceType set incorrectly before calling _eglLinkConfig(),
> and the bad value is passed around to platform_android. fix it.
>
Well done Varad, nicely spotted. I'm thinking that we perhaps should
set it to 0, as prior to the commit.
Otherwise the "clear EGL_PIXMAP_BIT, when we have a double_buffer",
below, won't kick in.

While you're here, can you please move the memcpy next to the
conf->base... assignments and add
Cc: mesa-stable at lists.freedesktop.org
Reviewed-by: Emil Velikov <emil.l.velikov at gmail.com>

Thanks
Emil


More information about the mesa-dev mailing list