[Mesa-dev] [PATCH 11.3/18] radeon: Don't override NewFramebuffer just to call _mesa_new_framebuffer

[Ian Romanick]

On 10/06/2015 11:28 AM, Alex Deucher wrote:
> On Tue, Oct 6, 2015 at 2:13 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>>
>> Signed-off-by: Ian Romanick <ian.d.romanick at intel.com>
> 
> Assuming the pointer is set correctly as per Brian's comments, this patch is:

It looks like r100CreateContext calls _mesa_init_driver_functions at
line 200, and it calls radeon_fbo_init at line 324.  r200CreateContext
calls _mesa_init_driver_functions at line 234, and it calls
radeon_fbo_init at line 284.  I think we should be good.

> Reviewed-by: Alex Deucher <alexander.deucher at amd.com>
> 
>> ---
>>  src/mesa/drivers/dri/radeon/radeon_fbo.c | 7 -------
>>  1 file changed, 7 deletions(-)
>>
>> diff --git a/src/mesa/drivers/dri/radeon/radeon_fbo.c b/src/mesa/drivers/dri/radeon/radeon_fbo.c
>> index 5eece51..4d75d14 100644
>> --- a/src/mesa/drivers/dri/radeon/radeon_fbo.c
>> +++ b/src/mesa/drivers/dri/radeon/radeon_fbo.c
>> @@ -46,12 +46,6 @@
>>                  printf(__VA_ARGS__);                      \
>>  } while(0)
>>
>> -static struct gl_framebuffer *
>> -radeon_new_framebuffer(struct gl_context *ctx, GLuint name)
>> -{
>> -  return _mesa_new_framebuffer(ctx, name);
>> -}
>> -
>>  static void
>>  radeon_delete_renderbuffer(struct gl_context *ctx, struct gl_renderbuffer *rb)
>>  {
>> @@ -868,7 +862,6 @@ radeon_validate_framebuffer(struct gl_context *ctx, struct gl_framebuffer *fb)
>>
>>  void radeon_fbo_init(struct radeon_context *radeon)
>>  {
>> -  radeon->glCtx.Driver.NewFramebuffer = radeon_new_framebuffer;
>>    radeon->glCtx.Driver.NewRenderbuffer = radeon_new_renderbuffer;
>>    radeon->glCtx.Driver.MapRenderbuffer = radeon_map_renderbuffer;
>>    radeon->glCtx.Driver.UnmapRenderbuffer = radeon_unmap_renderbuffer;
>> --
>> 2.1.0
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev
>