[Mesa-dev] [PATCH V7 19/24] glsl: Add AoA support when checking for non-const index

Samuel Iglesias Gonsálvez siglesias at igalia.com
Thu Oct 8 02:56:29 PDT 2015


Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>

On 07/10/15 00:47, Timothy Arceri wrote:
> When checking for non-const indexing of interfaces
> take into account arrays of arrays
> ---
>  src/glsl/ast_array_index.cpp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/src/glsl/ast_array_index.cpp b/src/glsl/ast_array_index.cpp
> index 5927c91..74d403f 100644
> --- a/src/glsl/ast_array_index.cpp
> +++ b/src/glsl/ast_array_index.cpp
> @@ -235,7 +235,7 @@ _mesa_ast_array_index_to_hir(void *mem_ctx,
>                    ir_var_shader_storage) {
>              _mesa_glsl_error(&loc, state, "unsized array index must be constant");
>           }
> -      } else if (array->type->fields.array->is_interface()
> +      } else if (array->type->without_array()->is_interface()
>                   && (array->variable_referenced()->data.mode == ir_var_uniform ||
>                       array->variable_referenced()->data.mode == ir_var_shader_storage)
>                   && !state->is_version(400, 0) && !state->ARB_gpu_shader5_enable) {
> 


More information about the mesa-dev mailing list