[Mesa-dev] [PATCH 01/12] i965: Move brw_dump_ir() out of brw_*_emit() functions

[Kristian Høgsberg]

On Thu, Oct 8, 2015 at 4:42 AM, Iago Toral <itoral at igalia.com> wrote:
> On Thu, 2015-10-08 at 12:32 +0100, Chris Wilson wrote:
>> On Thu, Oct 08, 2015 at 01:23:27PM +0200, Iago Toral wrote:
>> > Well, this is weird.... this patch makes this crash:
>> >
>> > INTEL_DEBUG=vs glxgears
>> >
>> > because that uses a vertex program, so &vs->base is a NULL pointer
>> > dereference in this call:
>> >
>> > brw_dump_ir("vertex", prog, &vs->base, &vp->program.Base);
>> >
>>
>> No, the crash is:
>>
>> > +   if (unlikely(INTEL_DEBUG & DEBUG_VS) && vs->base.ir)
>>
>> and friends.
>> -Chris
>
> Correct. We still need to patch calls to brw_dump_ir to fix this though.

No, what happened was I rebased this across Jasons recent cleanup and
didn't remove the vs->base.ir checks. I've removed them and verified
that glxgears works with INTEL_DEBUG=vs.

Kristian