[Mesa-dev] [PATCH] u_vbuf: fix vb slot assignment for translated buffers

Marek Olšák maraeo at gmail.com
Fri Oct 9 14:57:19 PDT 2015


Do you still have commit access and should somebody else push this?

Marek

On Sun, Oct 4, 2015 at 2:19 PM, Marek Olšák <maraeo at gmail.com> wrote:
> Oh, I forgot this:
>
> Reviewed-by: Marek Olšák <marek.olsak at amd.com>
>
> Marek
>
> On Sun, Oct 4, 2015 at 2:03 PM, Marek Olšák <maraeo at gmail.com> wrote:
>> Nice catch. Please add this to the commit message:
>>
>> Cc: mesa-stable at lists.freedesktop.org
>>
>> It will be automatically picked for 11.0 after you push it.
>>
>> Marek
>>
>> On Sun, Oct 4, 2015 at 12:09 PM, Nicolai Hähnle <nhaehnle at gmail.com> wrote:
>>> Vertex attributes of different categories (constant/per-instance/
>>> per-vertex) go into different buffers for translation, and this is now
>>> properly reflected in the vertex buffers passed to the driver.
>>>
>>> Fixes e.g. piglit's point-vertex-id divisor test.
>>> ---
>>>  src/gallium/auxiliary/util/u_vbuf.c | 1 +
>>>  1 file changed, 1 insertion(+)
>>>
>>> diff --git a/src/gallium/auxiliary/util/u_vbuf.c b/src/gallium/auxiliary/util/u_vbuf.c
>>> index 3d2193c..b31ada1 100644
>>> --- a/src/gallium/auxiliary/util/u_vbuf.c
>>> +++ b/src/gallium/auxiliary/util/u_vbuf.c
>>> @@ -544,6 +544,7 @@ u_vbuf_translate_find_free_vb_slots(struct u_vbuf *mgr,
>>>
>>>           index = ffs(unused_vb_mask) - 1;
>>>           fallback_vbs[type] = index;
>>> +         unused_vb_mask &= ~(1 << index);
>>>           /*printf("found slot=%i for type=%i\n", index, type);*/
>>>        }
>>>     }
>>> --
>>> 2.1.4
>>>
>>> _______________________________________________
>>> mesa-dev mailing list
>>> mesa-dev at lists.freedesktop.org
>>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev


More information about the mesa-dev mailing list