[Mesa-dev] [PATCH 1/9] glsl: Allow built-in functions as constant expressions in OpenGL ES 1.00
idr at freedesktop.org
Mon Oct 12 09:45:59 PDT 2015
On 10/09/2015 07:01 PM, Matt Turner wrote:
> On Fri, Oct 9, 2015 at 6:52 PM, Ian Romanick <idr at freedesktop.org> wrote:
>> From: Ian Romanick <ian.d.romanick at intel.com>
>> In d4a24745 (August 2012), Paul made functions calls not be constant
>> expressions in GLSL ES 1.00. Since this feature was added in desktop
>> GLSL 1.20, we believed that it was added in GLSL ES 3.00. That turns
>> out to be completely wrong. Built-in functions have always been allowed
>> as constant expressions in GLSL ES, and the patch adds the (many) spec
>> quotations to prove it.
>> While we never previously encountered this, a later patch enfoces a GLSL
> typo: enforces
>> ES 1.00 rule that global variable initializers must be constant
>> expressions. Without this fix, severl dEQP tests fail.
> typo: several
Heh... piglit was running, and there were a couple tests stealing focus.
I think those tests got the missing characters. :)
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
More information about the mesa-dev