[Mesa-dev] [PATCH V4 2/6] glsl: assign hidden uniforms their slot id earlier

[Michel Dänzer]

On 11.10.2015 16:20, Timothy Arceri wrote:
> On Sat, 2015-10-10 at 18:06 +0200, Marek Olšák wrote:
>> Hi Timothy,
>>
>> One of these 3 commits breaks compilation for Talos shaders with
>> gallium. My piglit patch "glsl-1.30/sampler-bug: ..." contains a
>> minimal test case. I can't say which commit, because Mesa fails to
>> build between them.
>>  It has something to do with uniforms, structures,
>> and samplers.
>>
>> commit dcd9cd03837545055ce2a315e7e8840cc3254d1a
>> Author: Timothy Arceri <t_arceri at yahoo.com.au>
>> Date:   Sun Aug 30 12:50:34 2015 +1000
>>
>>     glsl: store uniform slot id in var location field
>>
> 
> Hi Marek,
> 
> The piglit test passes on my intel based laptop I can't test on
> anything else until later this week (as I'm traveling) [...]

FWIW, surely you can test llvmpipe on that laptop? :)


-- 
Earthling Michel Dänzer               |               http://www.amd.com
Libre software enthusiast             |             Mesa and X developer