[Mesa-dev] [PATCH 16/16] nvc0: add a note about MP counters on GF100/GF110

[Samuel Pitoiset]

On 10/16/2015 07:50 PM, Ilia Mirkin wrote:
> Series is Reviewed-by: Ilia Mirkin <imirkin at alum.mit.edu>
>
> I had a couple of very minor comments that you can feel free to accept
> or ignore.

Thank you for this review Ilia, and I think I'll accept all of your 
changes. :)

>
> On Fri, Oct 16, 2015 at 1:22 PM, Samuel Pitoiset
> <samuel.pitoiset at gmail.com> wrote:
>> MP counters on GF100/GF110 (compute capability 2.0) are buggy
>> because there is a context-switch problem that we need to fix.
>> Results might be wrong sometimes, be careful!
>>
>> Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
>> ---
>>   src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_sm.c | 5 +++++
>>   1 file changed, 5 insertions(+)
>>
>> diff --git a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_sm.c b/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_sm.c
>> index c4b40a6..c5ce3e3 100644
>> --- a/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_sm.c
>> +++ b/src/gallium/drivers/nouveau/nvc0/nvc0_query_hw_sm.c
>> @@ -286,6 +286,11 @@ static const struct nvc0_hw_sm_query_cfg nve4_hw_sm_queries[] =
>>   #undef _M2B
>>
>>   /* === PERFORMANCE MONITORING COUNTERS for NVC0:NVE4 === */
>> +/* NOTES:
>> + * - MP counters on GF100/GF110 (compute capability 2.0) are buggy
>> + *   because there is a context-switch problem that we need to fix.
>> + *   Results might be wrong sometimes, be careful!
>> + */
>>   static const char *nvc0_hw_sm_query_names[] =
>>   {
>>      /* MP counters */
>> --
>> 2.6.1
>>
>> _______________________________________________
>> mesa-dev mailing list
>> mesa-dev at lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/mesa-dev