[Mesa-dev] [PATCH] st/mesa: fix clip state dependencies

Brian Paul brianp at vmware.com
Sat Oct 17 09:08:13 PDT 2015


On 10/17/2015 06:23 AM, Marek Olšák wrote:
> From: Marek Olšák <marek.olsak at amd.com>
>
> This allows removing FLUSH_VERTICES in MatrixMode.
>
> Cc: mesa-stable at lists.freedesktop.org
> ---
>   src/mesa/state_tracker/st_atom_clip.c | 5 ++++-
>   1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/src/mesa/state_tracker/st_atom_clip.c b/src/mesa/state_tracker/st_atom_clip.c
> index 506a770..b820d84 100644
> --- a/src/mesa/state_tracker/st_atom_clip.c
> +++ b/src/mesa/state_tracker/st_atom_clip.c
> @@ -56,6 +56,9 @@ static void update_clip( struct st_context *st )
>            use_eye = TRUE;
>      }
>
> +   /* _ClipUserPlane = _NEW_TRANSFORM | _NEW_PROJECTION
> +    * EyeUserPlane = _NEW_TRANSFORM
> +    */
>      memcpy(clip.ucp,
>             use_eye ? ctx->Transform.EyeUserPlane
>                     : ctx->Transform._ClipUserPlane, sizeof(clip.ucp));
> @@ -70,7 +73,7 @@ static void update_clip( struct st_context *st )
>   const struct st_tracked_state st_update_clip = {
>      "st_update_clip",					/* name */
>      {							/* dirty */
> -      _NEW_TRANSFORM,                                   /* mesa */
> +      _NEW_TRANSFORM | _NEW_PROJECTION,                 /* mesa */
>         ST_NEW_VERTEX_PROGRAM,				/* st */
>      },
>      update_clip						/* update */
>

That looks right.  Reviewed-by: Brian Paul <brianp at vmware.com>



More information about the mesa-dev mailing list