[Mesa-dev] [PATCH 01/10] tnl: add some comments in render_line_loop code

[Sinclair Yeh]

Patches 1-8 look good.  I'm spending a bit more time on 10.

Reviewed-by: Sinclair Yeh <syeh at vmware.com>
________________________________________
From: Brian Paul <brianp at vmware.com>
Sent: Friday, October 16, 2015 2:25 PM
To: mesa-dev at lists.freedesktop.org
Cc: Charmaine Lee; Jose Fonseca; Sinclair Yeh
Subject: [PATCH 01/10] tnl: add some comments in render_line_loop code

And remove '(void) flags' line which is not needed.
---
 src/mesa/tnl/t_vb_rendertmp.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/src/mesa/tnl/t_vb_rendertmp.h b/src/mesa/tnl/t_vb_rendertmp.h
index 44dee76..26a1695 100644
--- a/src/mesa/tnl/t_vb_rendertmp.h
+++ b/src/mesa/tnl/t_vb_rendertmp.h
@@ -124,19 +124,19 @@ static void TAG(render_line_loop)( struct gl_context *ctx,
    GLuint i;
    LOCAL_VARS;

-   (void) flags;
-
    INIT(GL_LINE_LOOP);

    if (start+1 < count) {
       if (TEST_PRIM_BEGIN(flags)) {
         RESET_STIPPLE;
+         /* draw the first line from v[0] to v[1] */
          if (ctx->Light.ProvokingVertex == GL_LAST_VERTEX_CONVENTION_EXT)
             RENDER_LINE( ELT(start), ELT(start+1) );
          else
             RENDER_LINE( ELT(start+1), ELT(start) );
       }

+      /* draw lines from v[1] to V[n-1] */
       for ( i = start+2 ; i < count ; i++) {
          if (ctx->Light.ProvokingVertex == GL_LAST_VERTEX_CONVENTION_EXT)
             RENDER_LINE( ELT(i-1), ELT(i) );
@@ -145,6 +145,7 @@ static void TAG(render_line_loop)( struct gl_context *ctx,
       }

       if ( TEST_PRIM_END(flags)) {
+         /* draw final line from v[n-1] to v[0] (the very first vertex) */
          if (ctx->Light.ProvokingVertex == GL_LAST_VERTEX_CONVENTION_EXT)
             RENDER_LINE( ELT(count-1), ELT(start) );
          else
--
1.9.1