[Mesa-dev] [PATCH] glsl: fix SSBO regression

[Samuel Iglesias Gonsálvez]

On 19/10/15 13:18, Samuel Iglesias Gonsálvez wrote:
> Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
> 

Just one thing I forgot to say, Can you be more verbose about what it
fixes in the subject line?

"glsl: fix regression when building interface field name for SSBOs"

or something like that.

Sam

> On 18/10/15 00:19, Timothy Arceri wrote:
>> Fixes regression cased by bb5aeb854915ba67abc56257f830d002c956439e
>>
>> We don't care about the swizzle when building the name so just skip over it.
>> ---
>>
>>  New piglit test: http://patchwork.freedesktop.org/patch/62111/ 
>>
>>  src/glsl/lower_ubo_reference.cpp | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/src/glsl/lower_ubo_reference.cpp b/src/glsl/lower_ubo_reference.cpp
>> index 1fbb09d..35469bf 100644
>> --- a/src/glsl/lower_ubo_reference.cpp
>> +++ b/src/glsl/lower_ubo_reference.cpp
>> @@ -238,6 +238,8 @@ interface_field_name(void *mem_ctx, char *base_name, ir_rvalue *d,
>>        case ir_type_swizzle: {
>>           ir_swizzle *s = (ir_swizzle *) ir;
>>           ir = s->val->as_dereference();
>> +         /* Skip swizzle in the next pass */
>> +         d = ir;
>>           break;
>>        }
>>  
>>