[Mesa-dev] Mesa (master): mesa: remove FLUSH_VERTICES() in _mesa_MatrixMode()

[Brian Paul]

On 10/19/2015 12:52 AM, Michel Dänzer wrote:
> On 17.10.2015 00:10, Brian Paul wrote:
>> On 10/16/2015 08:17 AM, Brian Paul wrote:
>>> On 10/16/2015 12:36 AM, Michel Dänzer wrote:
>>>>
>>>> Hi Brian,
>>>>
>>>>
>>>> On 15.10.2015 22:23, Brian Paul wrote:
>>>>> Module: Mesa
>>>>> Branch: master
>>>>> Commit: 0de5e0f3fb0f3671a3ecec6ab4473f9131ecd0ae
>>>>> URL:
>>>>> https://urldefense.proofpoint.com/v2/url?u=http-3A__cgit.freedesktop.org_mesa_mesa_commit_-3Fid-3D0de5e0f3fb0f3671a3ecec6ab4473f9131ecd0ae&d=BQIDaQ&c=Sqcl0Ez6M0X8aeM67LKIiDJAXVeAw-YihVMNtXt-uEs&r=T0t4QG7chq2ZwJo6wilkFznRSFy-8uDKartPGbomVj8&m=8sayHNUd839r9lIMSeT-XcC7Pgd2pvUFMx8M908uS1E&s=l0dFEwSLVXkyixgaBNadODlBRh4jy81TFLFucNg8BI8&e=
>>>>>
>>>>>
>>>>>
>>>>> Author: Brian Paul <brianp at vmware.com>
>>>>> Date:   Wed Oct 14 09:08:50 2015 -0600
>>>>>
>>>>> mesa: remove FLUSH_VERTICES() in _mesa_MatrixMode()
>>>>>
>>>>> Changing the matrix mode alone has no effect on rendering and does
>>>>> not need to trigger a flush or state validation.
>>>>
>>>> Famous last words. :)
>>>>
>>>> This change broke the piglit tests
>>>>
>>>> spec at arb_vertex_program@clip-plane-transformation arb
>>>> spec at glsl-1.10@execution at clipping@clip-plane-transformation fixed
>>>>
>>>> for me with radeonsi and llvmpipe.
>>>
>>> Hmm, I don't know how I missed that.  I did a full piglit run with that
>>> whole series of patches and didn't notice this.  I'll look into it.
>>> Thanks for catching it.
>>
>> I think I'll just have to revert this.  It looks like the state
>> tracker's update_clip() isn't getting called at some point and the
>> gallium driver doesn't get the updated clip planes.  I suspect my change
>> to matrix.c actually exposed a bug elsewhere, but I don't have time to
>> hunt it down right now.
>
> Thanks for reverting it.

Thanks to Marek for finding the right fix!

-Brian