[Mesa-dev] [RFC PATCH 00/40] Rework/consolidate the pipe-loader business

[Emil Velikov]

On 19 October 2015 at 17:07, Brian Paul <brianp at vmware.com> wrote:
> On 10/17/2015 04:57 PM, Emil Velikov wrote:
>>
>> Hi all,
>>
>> Here goes a series (which is slightly overdue), that reworks the
>> target-helpers into a pipe-loader like interface. As such the
>> state-tracker do not need to know that there is a difference between the
>> two and it only uses the pipe-loader interface.
>>
>> As we have the chance to build the targets with either static or dynamic
>> pipe-drivers, we need to add/more the inline drm (target helpers) to a
>> non-inlined version. Additionally we rework the swrast pipe-driver to
>> include the winsys, just like its hardware brethren.
>>
>> Finally I haven't exposed a configure switch to toggle between the
>> static/dynamic pipe-drivers, as I'm wondering if we should keep it as
>> "toggle all drivers to static/dynamic" or "one per target". I'm leaning
>> towards the former.
>>
>> I'm sending these as RFC mostly because I haven't got around to testing
>> it yet (plus the occasional question in the commit message).
>>
>>
>> Note; the series contains a fair few cleanups and refactoring along the
>> way which can be picked independently, if people feel strongly against
>> the core idea.
>>
>> Note2: the series is only build tested on scons+automake although I
>> would expect the Android build to work like a charm.
>>
>
> I'm not too familiar with this code or these changes but I'm wondering how
> much of chance there is of this breaking any driver/target builds.
>
> For example, is there a chance of breaking the VMware driver or Windows
> builds?  I don't have time to test this series here ATM, but I guess I could
> later this week.
>
Afaics the Windows builds are unaffected. On the  svga/vmwgfx front,
(of the top of my head) I'd say - 1-2% chance that things have
regressed (due to git rebase fallouts, as spotted with the missing
winsys->destroy).

But in all means please do give them a bash. These can wait a week or
so (but hopefully less than a month).

Thanks
Emil