[Mesa-dev] [PATCH 2/4] gallium: add new properties for clip and cull distance usage

Marek Olšák maraeo at gmail.com
Mon Oct 19 14:44:26 PDT 2015


On Mon, Oct 19, 2015 at 11:31 PM, Roland Scheidegger <sroland at vmware.com> wrote:
> Yes, but I still don't see much change from getting this information
> from the property rather than how tgsi_scan does it now, which is by
> just using the usage mask from the output declaration. So the writes
> shouldn't have to be analyzed.
> (There's also a slight change in patch 4/4, namely these outputs
> absolutely must be in order (xyzw) now as usage mask is determined
> solely by the number of values. That might already have been the case at
> least for some drivers and is probably ok for other state trackers too,
> it wasn't in the docs however.)

DCL OUT[1..2], ARRAY(1), CLIPDIST

CLIPDIST became an array declaration recently, so the usage mask isn't
useful unless it's extended to 8 bits.

Also, st/mesa doesn't set the usage mask for anything, so I wonder
whether we need it.

Marek


More information about the mesa-dev mailing list