[Mesa-dev] [PATCH] radeonsi: add support for ARB_texture_view

[Marek Olšák]

On Tue, Oct 20, 2015 at 5:26 PM, Ilia Mirkin <imirkin at alum.mit.edu> wrote:
> On Sat, Oct 17, 2015 at 9:09 AM, Marek Olšák <maraeo at gmail.com> wrote:
>> +       /* This is not needed if state trackers set last_layer correctly. */
>> +       if (state->target == PIPE_TEXTURE_1D ||
>> +           state->target == PIPE_TEXTURE_2D ||
>> +           state->target == PIPE_TEXTURE_RECT ||
>> +           state->target == PIPE_TEXTURE_CUBE)
>> +               last_layer = state->u.tex.first_layer;
>> +
>
> Did you observe state trackers messing this one up, or just being
> defensive? Also for cube, normally last layer would be first_layer +
> 5...

I'm just being defensive.

The hardware does the right thing if target == CUBE. first_layer ==
last_layer has no effect on cubemaps.

Marek