[Mesa-dev] [Bug 92552] [softpipe] piglit egl-create-context-valid-flag-forward-compatible-gl regression

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=92552

Boyan Ding <stu_dby at 126.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
          Component|Mesa core                   |EGL

--- Comment #4 from Boyan Ding <stu_dby at 126.com> ---
(In reply to Matthew Waters from comment #2)
> Created attachment 119006 [details] [review]
> egl: distnguish between unsupported api vs capabilities for EGL_CONTEXT_FLAGS
> 
> This fixes that issue for me.

Well, your patch does seem to eliminate the problem, but there is a subtle
difference between how things works now and before, which I think may be
questionable.

The spec of EGL_KHR_create_context says:
    requesting a forward-compatible context for OpenGL versions less
    than 3.0 will generate an error

The code now takes "OpenGL version" above as version requested with EGL (1.0 by
default). However, the OpenGL version actually provided can be up to 3.0. In
such case, your patch will fail to create forward-compatible context, giving
the "appropriate" error, while mesa before 86ccb2a1 will succeed. Though both
behaviors pass piglit.

Any ideas?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are the assignee for the bug.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151020/7bed6b06/attachment.html>