[Mesa-dev] [RFC 21/21] mesa/extensions: Declare _mesa_init_extensions() static inline

Nanley Chery nanleychery at gmail.com
Tue Oct 20 09:38:27 PDT 2015


On Tue, Oct 20, 2015 at 9:31 AM, Marek Olšák <maraeo at gmail.com> wrote:

> On Tue, Oct 20, 2015 at 6:25 PM, Nanley Chery <nanleychery at gmail.com>
> wrote:
> >
> >
> > On Tue, Oct 20, 2015 at 8:57 AM, Marek Olšák <maraeo at gmail.com> wrote:
> >>
> >> On Tue, Oct 20, 2015 at 12:44 AM, Nanley Chery <nanleychery at gmail.com>
> >> wrote:
> >> > From: Nanley Chery <nanley.g.chery at intel.com>
> >> >
> >> > Avoid the function call overhead for this one-liner.
> >>
> >> Can you measure the overhead? If not, there is no reason for this
> change.
> >>
> >
> > The .text size does decrease by 48 bytes:
> >          text       data         bss           dec         hex filename
> > 5190616  209856   27712 5428184  52d3d8 lib/i965_dri.so (before)
> > 5190568  209856   27712 5428136  52d3a8 lib/i965_dri.so (after)
> >
> > Is this sufficient? If so, I can add the snippet above to the git
> comment.
>
> I don't think so. :)
>
>
:) Okay. I suppose that the function isn't called often enough to warrant
the loss of encapsulation.

Thanks,
Nanley


> Marek
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.freedesktop.org/archives/mesa-dev/attachments/20151020/311d56f3/attachment.html>


More information about the mesa-dev mailing list