[Mesa-dev] [PATCH 0/7] ARB_shader_clock support

Emil Velikov emil.l.velikov at gmail.com
Tue Oct 20 10:06:41 PDT 2015


On 19 October 2015 at 19:39, Matt Turner <mattst88 at gmail.com> wrote:
> On Mon, Oct 19, 2015 at 7:45 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
>> Hi all,
>>
>> This is a resent of the previous RFC series with a few minor changes
>>  - fs_reg:;smear() has been moved out of get_timestamp()
>>  - clock2x32ARB() has proper return value
>>  - the nir intrinsic no longer claims to have a variable
>>
>> I'm still rocking a SNB hardware so I did not really got the chance to
>> test this properly. Any reviews and testers will be greatly appreciated.
>
> Assuming I didn't miss something in my comment on 6/7, the series looks correct.
>
> Reviewed-by: Matt Turner <mattst88 at gmail.com>
>
Thanks Matt. I've resent the few problematic patches, and will add
your r-b if you still think they're ok.

> But let's wait until we have piglit tests in place (for both VS and
> FS) before committing it. I'd like to do some testing myself as well.
>
> Thanks Emil. Hopefully we'll get you some hardware you can test on. :)
Hope so too. It has been a bit of stab in the dark with these I so
hopefully I haven't butchered things too much.

The updated series can be found over at
https://github.com/evelikov/Mesa/tree/for-upstream/arb-shader-clock

-Emil


More information about the mesa-dev mailing list