[Mesa-dev] [PATCH 2/6] i965/fs: Enumerate logical fb writes arguments

Matt Turner mattst88 at gmail.com
Tue Oct 20 15:33:52 PDT 2015

On Tue, Oct 20, 2015 at 3:27 PM, Ben Widawsky <ben at bwidawsk.net> wrote:
> On Tue, Oct 20, 2015 at 03:19:48PM -0700, Matt Turner wrote:
>> What I should have said in the previous email is that assigning
>> arbitrary numbers to enums in brw_defines.h is confusing because one
>> might be led to believe that these are hardware values (like almost
>> everything else is in brw_defines.h).
> Oh. I see what you mean. Yeah, I can drop the explicit numbering. You're cool
> with the enumeration though?

Yep, using the enumeration is a big improvement. Thanks for doing that.

More information about the mesa-dev mailing list