[Mesa-dev] [PATCH 3/7] glsl: add AoA support to subroutines

[Timothy Arceri]

On Wed, 2015-10-21 at 13:28 +1000, Dave Airlie wrote:
> On 16 October 2015 at 12:51, Timothy Arceri <t_arceri at yahoo.com.au>
> wrote:
> > On Fri, 2015-10-16 at 11:44 +1000, Dave Airlie wrote:
> > > you gotta give me something in the commit msg to have any idea
> > > what
> > > I'm reading here :-)
> > > 
> > > why does process_parameters move?
> > 
> > Because we need actual_parameters processed earlier so we can use
> > it
> > with match_subroutine_by_name() to get the subroutine variable, we
> > need
> > to do this inside the recursive function generate_array_index()
> > because
> > we can't create the ir_dereference_array() until we have gotten to
> > the
> > outermost array.
> > 
> > For the remainder of the array dimensions the type doesn't matter
> > so we
> > can just use the existing _mesa_ast_array_index_to_hir() function
> > to
> > process the ast.
> 
> Okay makes sense,
> 
> for what it's worth!
> Reviewed-by: Dave Airlie <airlied at redhat.com>

Thanks Dave, I updated the commit msg with a similar explanation and
pushed.

> 
> Dave.
> > 
> > Hope that makes sense.
> > 
> > > 
> > > is there a piglit for subroutine/arrays?
> > 
> > Just a simple one that extends one of yours tests for AoA
> > 
> > spec/arb_arrays_of_arrays/execution/subroutines/fs
> > -subroutine.shader_test
> > 
> > > 
> > > Dave.
> _______________________________________________
> mesa-dev mailing list
> mesa-dev at lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/mesa-dev