[Mesa-dev] [PATCH 4/4] mesa: Draw indirect is not allowed when xfb is active and unpaused

[Tapani Pälli]

On 10/20/2015 05:19 PM, Marta Lofstedt wrote:
> From: Marta Lofstedt <marta.lofstedt at intel.com>
>
> OpenGL ES 3.1 specification, section 10.5:
> "An INVALID_OPERATION error is generated if
> transform feedback is active and not paused."
>
> Signed-off-by: Marta Lofstedt <marta.lofstedt at linux.intel.com>
> ---
>   src/mesa/main/api_validate.c | 9 +++++++++
>   1 file changed, 9 insertions(+)
>
> diff --git a/src/mesa/main/api_validate.c b/src/mesa/main/api_validate.c
> index a084362..cb6112f 100644
> --- a/src/mesa/main/api_validate.c
> +++ b/src/mesa/main/api_validate.c
> @@ -711,6 +711,15 @@ valid_draw_indirect(struct gl_context *ctx,
>         return GL_FALSE;
>      }
>   
> +   /* OpenGL ES 3.1 specification, section 10.5:
> +    * "An INVALID_OPERATION error is generated if
> +    * transform feedback is active and not paused."
> +    */
> +   if (_mesa_is_gles31(ctx) && _mesa_is_xfb_active_and_unpaused(ctx)) {
> +      _mesa_error(ctx, GL_INVALID_OPERATION,
> +                  "%s(TransformFeedback is active but not paused)", name);

better go with "and not paused" here like spec says;

Reviewed-by: Tapani Pälli <tapani.palli at intel.com>

> +   }
> +
>      /*
>       * OpenGL ES 3.1 spec. section 10.5:
>       * "An INVALID_OPERATION error is generated if zero is bound to