[Mesa-dev] [PATCH 4/9] i965: Compact acc_wr_control only on Gen6+.

Iago Toral itoral at igalia.com
Tue Oct 20 23:33:35 PDT 2015


On Tue, 2015-10-20 at 11:38 -0700, Matt Turner wrote:
> On Tue, Oct 20, 2015 at 1:51 AM, Iago Toral <itoral at igalia.com> wrote:
> > On Mon, 2015-10-19 at 21:09 -0700, Matt Turner wrote:
> >> It only exists on Gen6+, and the next patches will add compaction
> >> support for the (unused) field in the same location on earlier
> >> platforms.
> >
> > The docs say that this exists also in ILK at least. See Page 131 of:
> > https://01.org/sites/default/files/documentation/ilk_ihd_os_vol4_part2_july_28_10_0.pdf
> >
> > However, I see some places in the i965 code where dealing with this is
> > surrounded by if (gen >= 6)...
> >
> > Is this a bug in the ILK documentation?
> 
> Yes. The ILK docs are terrible and contain more SNB documentation than
> ILK documentation. :(

Ugh! :( Anyway, in that case, patches 4-6 are:

Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>

Iago



More information about the mesa-dev mailing list