[Mesa-dev] [PATCHv4 4/7] nir: add shader_clock intrinsic

[Emil Velikov]

On 20 October 2015 at 19:58, Connor Abbott <cwabbott0 at gmail.com> wrote:
> On Tue, Oct 20, 2015 at 12:55 PM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
[snip]
>> +/*
>> + * Shader clock intrinsic with semantics analogous to the clock2x32ARB()
>> + * GLSL intrinsic.
>> + * The latter can be used as code motion barrier, which is currently not
>> + * feasible with NIR, thus we can eliminate the intrinsic when the return
>> + * value is unused.
>
> Just a small bikeshedding thing: technically, even if we were to make
> shader_clock a code motion barrier like the spec asks for, we could
> still delete it if its result is unused because then nobody will
> notice if we move code around it. Get rid of the "thus we can
> eliminate..." bit and this is
>
Indeed you're correct. It won't make much sense to keep in around.

Thanks for the suggestions and review.
Emil