[Mesa-dev] [PATCH 1/2] i965: remove cache_aux_free_func array

[Emil Velikov]

On 21 October 2015 at 21:33, Kenneth Graunke <kenneth at whitecape.org> wrote:
> On Monday, October 19, 2015 02:54:56 PM Emil Velikov wrote:
>> Ping on these two trivial patches ?
>>
>> -Emil
>
> Oh, sorry, I thought I'd sent R-bs for these...
>
> Both are
> Reviewed-by: Kenneth Graunke <kenneth at whitecape.org>
Thanks Ken. I was wondering if people looked at them and went "meh ...
too small, we need something beefier" :-P

And now ... some C++ questions. I realise that templates (or is it
only STL?) are out of the question, but how about
 - Initialization upon object declaration, rather than copy
constructors ? Rather trivial yet we have thousands of
duplicated/wasted CPU cycles due to it. One example is the memset()
from {fs,src,dst}_reg. Does the compiler squash/optimize those for us
?
 - Where is the line about "big enough to pass as reference" rather
than a copy for i965 ? It seems that older code(?) and extremely
common things such as the *_reg are passed around as copies.

Cheers,
Emil