[Mesa-dev] [PATCH] gallivm: Translate all util_cpu_caps bits to LLVM attributes.

[Jose Fonseca]

On 21/10/15 17:35, Gustaw Smolarczyk wrote:
> I am just a bystander, but I have one suggestion to this patch.
>
> 2015-10-21 18:25 GMT+02:00 Jose Fonseca <jfonseca at vmware.com>:
>> This should prevent disparity between features Mesa and LLVM
>> believe are supported by the CPU.
>>
>> http://lists.freedesktop.org/archives/mesa-dev/2015-October/thread.html#96990
>>
>> Tested on a i7-3720QM w/ LLVM 3.3 and 3.6.
>> ---
>>   src/gallium/auxiliary/gallivm/lp_bld_misc.cpp | 34 ++++++++++++++++++++++++++-
>>   1 file changed, 33 insertions(+), 1 deletion(-)
>>
>> diff --git a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
>> index 72fab8c..7073956 100644
>> --- a/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
>> +++ b/src/gallium/auxiliary/gallivm/lp_bld_misc.cpp
>> @@ -498,6 +498,32 @@ lp_build_create_jit_compiler_for_module(LLVMExecutionEngineRef *OutJIT,
>>      }
>>
>>      llvm::SmallVector<std::string, 1> MAttrs;
>
> Maybe increase the size of the SmallVector here?
>
> Gustaw

Good point. Will do. Thanks.

Jose