[Mesa-dev] [PATCH 7/9] i965: Add initial assembly validation pass.

Matt Turner mattst88 at gmail.com
Thu Oct 22 11:27:21 PDT 2015


On Thu, Oct 22, 2015 at 4:15 AM, Emil Velikov <emil.l.velikov at gmail.com> wrote:
> On 21 October 2015 at 23:58, Matt Turner <mattst88 at gmail.com> wrote:
>> Initially just checks that sources are non-NULL, which would have
>> alerted us to the problem fixed by commit 6c846dc5.
>
> What are the chances of combining this with and/or removing
> fs_visitor::validate() ? Afaict both of these validations are at
> different level and we do not have enough information within
> brw_validate_instructions(), do we ?

Right, they'll validate different sets of things (that aren't possible
for the other to validate), so both are useful and complementary.


More information about the mesa-dev mailing list