[Mesa-dev] [RFC 07/21] mesa/extensions: Use _mesa_extension_supported()

[Matt Turner]

On Thu, Oct 22, 2015 at 11:15 AM, Chad Versace <chad.versace at intel.com> wrote:
> On Mon 19 Oct 2015, Nanley Chery wrote:
>> From: Nanley Chery <nanley.g.chery at intel.com>
>>
>> Replace open-coded checks for extension support with
>> _mesa_extension_supported().
>>
>> Signed-off-by: Nanley Chery <nanley.g.chery at intel.com>
>> ---
>>  src/mesa/main/extensions.c       | 54 ++++++++--------------------------------
>>  src/mesa/main/extensions_table.h |  6 ++---
>>  2 files changed, 14 insertions(+), 46 deletions(-)
>>
>> diff --git a/src/mesa/main/extensions.c b/src/mesa/main/extensions.c
>> index 7137bc9..5d2eb1d 100644
>> --- a/src/mesa/main/extensions.c
>> +++ b/src/mesa/main/extensions.c
>> @@ -49,8 +49,6 @@ enum {
>>     GL  = (1 << API_OPENGL_COMPAT) | (1 << API_OPENGL_CORE),
>>     ES1 = 1 << API_OPENGLES,
>>     ES2 = 1 << API_OPENGLES2,
>> -   ES3 = 1 << (API_OPENGL_LAST + 1),
>> -   ES31 = 1 << (API_OPENGL_LAST + 2),
>
> I like the removal of the ES3 and ES31 tokens. There are only 4 GL APIs
> (compat, core, es1, and es2), and the enum now better reflects that.

To be clear, they were a kludge to work around Mesa's inability to
expose extensions based on API version. If we're adding that ability,
I agree it's awesome to get rid of these. :)